D9333: Make sure that old ulrs does not appear duplicated in places model

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> placesitemmodel.cpp:59
>      const char AppNamePrefix[] = "-places-panel";
> +    static QList<QUrl> baloonUrls = {
> +        QUrl(QStringLiteral("timeline:/today")),

baloonUrls -> balooURLs

> placesitemmodel.cpp:620
> +{
> +    // KIO model now provides support for ballon urls, and because of that we
> +    // need to remove old ulrs that was visibile only on dolphin to avoid duplication

ballon -> baloo

> placesitemmodel.cpp:621
> +    // KIO model now provides support for ballon urls, and because of that we
> +    // need to remove old ulrs that was visibile only on dolphin to avoid duplication
> +    int row = 0;

need to remove old ulrs that was visibile only on dolphin to avoid duplication

->

need to remove old URLs that were visible only in Dolphin to avoid duplication

> placesitemmodel.cpp:630
> +        if ((appName == KAboutData::applicationData().componentName() ||
> +             appName == KAboutData::applicationData().componentName() + AppNamePrefix) && baloonUrls.contains(url)) {
> +            qCDebug(DolphinDebug) << "Removing old ballon url:" << url;

baloonUrls -> balooURLs

> placesitemmodel.cpp:631
> +             appName == KAboutData::applicationData().componentName() + AppNamePrefix) && baloonUrls.contains(url)) {
> +            qCDebug(DolphinDebug) << "Removing old ballon url:" << url;
> +            m_sourceModel->removePlace(sourceIndex);

ballon -> baloo

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D9333

To: renatoo, mwolff
Cc: ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171214/e3daf62d/attachment.htm>