D8855: Use Kio::KPlacesModel as source model for PlacesItemModel

Renato Oliveira Filho noreply at phabricator.kde.org
Wed Dec 6 12:49:11 GMT 2017


renatoo marked an inline comment as done.
renatoo added inline comments.

INLINE COMMENTS

> mwolff wrote in placesitem.cpp:159
> shouldn't this be equality comparisons instead of contains checks? are there schemas like "foobar-search-asdf" that need to be matched too?

well the search can be "search://" or "baloonsearch://" not sure if anything else. "timeline" I think is fixed there is no variation.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D8855

To: renatoo, elvisangelaccio, emmanuelp, mlaurent, mwolff
Cc: mwolff, mlaurent, anthonyfieroni, nicolasfella, ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171206/c4f4aee0/attachment.htm>


More information about the kfm-devel mailing list