D9094: Use a faster way to determine kio-stash isn't installed

[Eike Hein]

hein added a comment.


  It's tricky. On the face of it you're right, because what the action does is open a view using the ioslave, and yes, it shouldn't be aware of the implementation details.
  
  Here's the best argument for it: The protocol being known isn't the same as kio-stash actually working, because if the service isn't registered then even if the protocol is known the stash won't work anyway. You can therefore argue that this code better captures intent - the action will actually work if this requirement is satisfied.
  
  It would be nicer if the "aware of implementation details" part were encapsulated within kio-stash itself, i.e. if it could supply this action as a plugin to Dolphin. But Dolphin isn't currently extensible in this way, so given that this action being in Dolphin code is suboptimal to begin with (it's coded against an ioslave it doesn't install itself), I still think this patch is a pragmatic way forward as it improves both performance and reliability.
  
  To sum it up: This should be done in a more proper way (kio-stash adding this action to Dolphin in some way knowing when it can be enabled), but in the meantime there's no good reason for it to be slower and less reliable.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D9094

To: hein, davidedmundson, elvisangelaccio, shortstheory
Cc: emmanuelp, alexeymin, ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171204/6c368f5c/attachment.htm>