D6312: Keep renamed file(s) in view

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dolphinview.cpp:1762
> +    clearSelection();
> +    m_clearSelectionBeforeSelectingNewItems = true;
> +    markUrlAsCurrent(current);

The old code did not have this assignment. Is it really necessary?

> dolphinview.h:315
>  
> +    void slotRenameDialogRenamingFinished(const QList<QUrl>& urls);
> +

I'd just call it `slotRenamingFinished()`. Also, no need to have it public, make it a private slot.

> renamedialog.cpp:42
>      m_newName(),
> +    m_renamedItems(),
>      m_lineEdit(0),

Not really necessary, default QList ctor is automatically called.

> renamedialog.cpp:246
>  }
> -

Unrelated whitespace change.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D6312

To: emateli, #dolphin, elvisangelaccio
Cc: elvisangelaccio, ltoscano, dfaure, #konqueror, #dolphin, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170830/51fb53aa/attachment.htm>