D7477: Limit folder panel to home directory if inside home

[Robert Hoffmann]

hoffmannrobert marked 4 inline comments as done.
hoffmannrobert added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in folderspanel.cpp:353
> The condition here is different from `(homeUrl.isParentOf(url) || homeUrl == url)` used above. Is this intended? Why?

At this point, a previous selection needs to be cleared, only if homeUrl == url. The previous selection won't correspond to the currently active home directory.

If homeUrl is a parent of url and not equal, the selection is correctly changed.

> elvisangelaccio wrote in folderspanel.cpp:366
> Why this change?

I changed this, because the selection wasn't updated correctly. But if I change it back, I cannot reproduce this behaviour now. The change in kfileitemmodel.cpp has fixed this, too, so I removed the change here.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7477

To: hoffmannrobert, #dolphin, elvisangelaccio
Cc: elvisangelaccio, #konqueror, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170828/a1fe2f9a/attachment.htm>