D7571: Enable modifying root-owned files in Dolphin

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Looks good, much simpler than the initial patch! (thanks to https://phabricator.kde.org/D7563)

INLINE COMMENTS

> dolphinmainwindow.cpp:1323-1334
> +        bool enableRename = true;
> +        if (list.count() > 1 && capabilities.isLocal()) {
> +            foreach (const KFileItem &item, list) {
> +                const QString parentDir = item.url().adjusted(QUrl::RemoveFilename | QUrl::StripTrailingSlash).toLocalFile();
> +                enableRename = enableRename && QFileInfo(parentDir).isWritable();
> +                if (!enableRename) {
> +                    break;

Why not exploit https://phabricator.kde.org/D7563 also for renaming?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7571

To: chinmoyr, #dolphin, dfaure, emmanuelp
Cc: elvisangelaccio, #konqueror
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170827/3d9f988e/attachment.htm>