D7477: Limit folder panel to home directory if inside home

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> folderspanel.cpp:327
>      QUrl baseUrl;
> +    const QUrl homeUrl(QUrl::fromLocalFile(GeneralSettings::homeUrl()));
>      if (url.isLocalFile()) {

Use `Dolphin::homeUrl()` from global.h

> folderspanel.cpp:353
> +
> +        if (FoldersPanelSettings::limitFoldersPanelToHome() && homeUrl == url) {
> +            KItemListSelectionManager* selectionManager = m_controller->selectionManager();

The condition here is different from `(homeUrl.isParentOf(url) || homeUrl == url)` used above. Is this intended? Why?

> folderspanel.cpp:366
>      selectionManager->clearSelection();
> +    selectionManager->setCurrentItem(index);
>      selectionManager->setSelected(index);

Why this change?

> treeviewcontextmenu.cpp:128
> +    // insert 'Limit folders panel to home directory if inside home'
> +    QAction* limitFoldersPanelToHomeAction = new QAction(i18nc("@action:inmenu", "Limit folders panel to home directory if inside home"), this);
> +    limitFoldersPanelToHomeAction->setCheckable(true);

"folder panel" is kinda redundant/implicit now, maybe just use ""Limit to home directory if inside home"

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7477

To: hoffmannrobert, #dolphin, elvisangelaccio
Cc: elvisangelaccio, #konqueror, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170825/493027aa/attachment.htm>