D7519: Fix DolphinRemoveAction Shift toggling on Wayland

Elvis Angelaccio noreply at phabricator.kde.org
Thu Aug 24 18:50:23 BST 2017


elvisangelaccio added a comment.


  In https://phabricator.kde.org/D7519#139553, @elvisangelaccio wrote:
  
  > In https://phabricator.kde.org/D7519#139529, @dfaure wrote:
  >
  > > Looks ok to me, but it's not documented that QGuiApplication::keyboardModifiers() doesn't work on wayland. Do you know if it will never work (->submit a patch for documentation) or it just hasn't been implemented (-> is there a bug report open?)
  >
  >
  > QGuiApplication::keyboardModifiers() does work, I meant QGuiApplication::queryKeyboardModifiers(), which is actually QPlatformIntegration::queryKeyboardModifiers().
  >  The default implementation is just QGuiApplication::keyboardModifiers(). I suppose this is a missing re-implementation in some QPA (kwin?), which would explain why bug #354301 reappeared (see https://phabricator.kde.org/R318:3775ef19eaca057985b92cfa3716d3c3a1d22f0f). But I'm not aware of bug reports about this.
  
  
  Filed one against kwin https://bugs.kde.org/show_bug.cgi?id=383966

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7519

To: elvisangelaccio, #dolphin
Cc: dfaure, #konqueror
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170824/a012ebdc/attachment.htm>


More information about the kfm-devel mailing list