D7477: Limit folder panel to home directory if inside home

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Thanks for the contribution.
  There is a small regression: if I enable the settings, the folder panel no longer follows the URL of the main dolphin view. Is that intended?

INLINE COMMENTS

> folderspanel.cpp:183
>  
> -    loadTree(url());
> +    if (url().isValid()) loadTree(url());
>      Panel::showEvent(event);

Coding style: missing braces

> dolphin_generalsettings.kcfg:65-68
> +        <entry name="LimitFolderPanelToHome" type="Bool">
> +            <label>Limit folder panel to home directory if inside home</label>
> +            <default>false</default>
> +        </entry>

Use `dolphin_folderspanelsettings.kcfg` instead.

Also, the default should probably be true (see https://bugs.kde.org/show_bug.cgi?id=191917).

> behaviorsettingspage.cpp:87
> +    // 'Limit folder panel to home directory if inside home'
> +    m_limitFolderPanelToHome = new QCheckBox(i18nc("option:check", "Limit folder panel to home directory if inside home"), this);
> +

I don't think we should add a checkbox in the main settings dialog, we could just add it in the context menu of the panel (treeviewcontextmenu.cpp).

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7477

To: hoffmannrobert
Cc: elvisangelaccio, #konqueror, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170823/9a8d805f/attachment.htm>