D7014: closing split view closes the currently focused view instead of the inactive

[Christoph Feck]

cfeck requested changes to this revision.
cfeck added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dolphinmainwindow.cpp:545
>      tabPage->setSplitViewEnabled(false);
> -    tabPage->setSplitViewEnabled(true, QUrl("stash:/"));
> +    tabPage->setSplitViewEnabled(true, true, QUrl("stash:/"));
>  }

https://ariya.io/2011/08/hall-of-api-shame-boolean-trap
https://wiki.qt.io/API_Design_Principles#The_Boolean_Parameter_Trap

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7014

To: McPain, #dolphin, elvisangelaccio, cfeck
Cc: cfeck, #konqueror, #dolphin, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170806/56766541/attachment.htm>