Review Request 130068: Patch to sort the tag-values alphabetically in the "Tags" column of Dolphin.

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130068/#review103150
-----------------------------------------------------------


Ship it!




Looks good to me.

- Mark Gaiser


On apr 28, 2017, 9:45 a.m., Athanasios Kanellopoulos wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130068/
> -----------------------------------------------------------
> 
> (Updated apr 28, 2017, 9:45 a.m.)
> 
> 
> Review request for Baloo and Dolphin.
> 
> 
> Bugs: 377589
>     https://bugs.kde.org/show_bug.cgi?id=377589
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Up until now tag-values have appeared unsorted in the Tags column
> when the selected View Mode is "Details".
> In older versions of Dolphin (in KDE4) the tags-values were
> alphabetically sorted in the Tags column, which means that back then
> this was the desired behavior.
> This commit restores this functionality.
> 
> 
> Related to the following commit:
> https://github.com/KDE/dolphin/pull/1/commits/12b82915f7c15ddb3b5c647bfd5ce2e2cdbe734c
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/private/kbaloorolesprovider.h a9bd2e8 
>   src/kitemviews/private/kbaloorolesprovider.cpp 16e3935 
> 
> Diff: https://git.reviewboard.kde.org/r/130068/diff/
> 
> 
> Testing
> -------
> 
> I built dolphin on my "KDE Neon Developer Edition" environment having applied this patch. No problems appeared during the build.
> 
> The tag-values now appear sorted alphabetically in the "Tags" column of Dolphin.
> 
> No further testing done.
> 
> 
> Thanks,
> 
> Athanasios Kanellopoulos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170428/10856463/attachment.htm>