Review Request 129936: Added a 'save search' button to the dolphin search bar. Not ready to be shipped.

[Ryan McCoskrie]

> On Feb. 18, 2017, 10:15 p.m., Emmanuel Pescosta wrote:
> > Thanks for the patch!
> > 
> > I don't think that we should add another way to bookmark the current search.
> > The same can already be achieved by either dragging it to the places panel or by doing RMB -> Add to places. The search folders then appears in the group "Search for".
> > From a user point of view this is the same as bookmarking a normal folders, thus the user is already aware of this workflow.
> > 
> > What do you (and others) think?

Sorry for taking so long. I'm okay with closing this as a non-issue if that is what you think is best.


- Ryan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129936/#review102551
-----------------------------------------------------------


On Feb. 9, 2017, 12:27 p.m., Ryan McCoskrie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129936/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2017, 12:27 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Bug 269332: Save Search button
> 
> 
> Diffs
> -----
> 
>   src/search/dolphinsearchbox.h 5063c2b 
>   src/search/dolphinsearchbox.cpp 5d5906b 
> 
> Diff: https://git.reviewboard.kde.org/r/129936/diff/
> 
> 
> Testing
> -------
> 
> - Discovered testing builds are broken, built without.
> - Saved a search for 'foo' in my home directory.
> - The name was "(I18N_EMPTY_MESSAGE)" but it was a valid link.
> 
> 
> Thanks,
> 
> Ryan McCoskrie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170410/60fe777c/attachment.htm>