Review Request 130028: Add a dedicated 'Copy To Stash' context menu button for the upcoming stash:/ ioslave

[arnav dhamija]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130028/
-----------------------------------------------------------

(Updated April 3, 2017, 5:54 p.m.)


Review request for Dolphin, Boudhayan Gupta, David Faure, and Emmanuel Pescosta.


Changes
-------

Fixed up with i18nc. Bumping for a final check and more comments.


Repository: dolphin


Description
-------

This patch adds a dedicated Copy to Stash button in Dolphin's context menu when items are selected in a group. Triggering this action adds the selected items to the clipboard and pastes it on the stash:/ ioslave.

I have encountered some problems when writing this patch. For one, though the QAction appears in the context menu as expected, it does not show up in the Menubar's File Menu though it is added under that in the dolphinui.rc file. Apart from this, the patch works fine in manual testing.


Diffs (updated)
-----

  src/dolphincontextmenu.cpp 890494f 
  src/dolphinmainwindow.h d741eb2 
  src/dolphinmainwindow.cpp de8601d 
  src/dolphinpart.rc 725320b 
  src/dolphinui.rc c446656 
  src/views/dolphinview.h 5e69fd3 
  src/views/dolphinview.cpp 63f6252 

Diff: https://git.reviewboard.kde.org/r/130028/diff/


Testing
-------


File Attachments
----------------

Context menu
  https://git.reviewboard.kde.org/media/uploaded/files/2017/03/19/085a8a51-86a7-4647-b5ae-fc8f0f599026__Screenshot_20170319_095338.png
patch
  https://git.reviewboard.kde.org/media/uploaded/files/2017/03/19/576bfbe8-eef7-4695-a77e-32e3c9e2c48f__patch


Thanks,

arnav dhamija

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170403/973b676a/attachment.htm>