Review Request 128964: Change "date" role name to "modificationtime" to be more informative and consistent with changes in request 128942(Adding Accessed time property)

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128964/#review99651
-----------------------------------------------------------




src/kitemviews/kfileitemmodel.cpp (line 2219)
<https://git.reviewboard.kde.org/r/128964/#comment67002>

    Ah please also change `DateRole` to `ModificationTimeRole` and "Date" label to "Modified" with this patch


- Emmanuel Pescosta


On Sept. 21, 2016, 5 a.m., Don Nguyen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128964/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2016, 5 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This bumps the Version in .directory config to 4.  The two changes are the addition of a "accesstime" role name, and change of "date" role name to "modificationtime".  The reason for this is supplement the changes in request 128942(Adding Accessed time property).  That change will add the new "accesstime" role name, and it makes sense to change the "date" role name to "modificationtime" at the same time.  This implementation will read and convert older config Version(<4) by the new function ViewProperties::convertDateRoleToModificationTimeRole().
> I am guessing at what all the different version numbers mean, so please let me know if I'm interpreting them wrong.
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kfileitemlistwidget.cpp 7e5b4bb 
>   src/kitemviews/kfileitemmodel.cpp 1f94972 
>   src/panels/places/placesitemmodel.cpp 25c4d51 
>   src/settings/viewpropertiesdialog.cpp 7407042 
>   src/tests/kfileitemmodeltest.cpp 6c45e11 
>   src/views/viewproperties.h dc118e2 
>   src/views/viewproperties.cpp 597baa2 
> 
> Diff: https://git.reviewboard.kde.org/r/128964/diff/
> 
> 
> Testing
> -------
> 
> Tested that it displays Date properly, writes out the new "modificationtime" to .directory file after a change, and loads and displays Date properly after reading int he new .directory file.  
> "make test" passes
> 
> 
> Thanks,
> 
> Don Nguyen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160929/88fe8b18/attachment.htm>