Review Request 129044: Adding a dedicated Stash action button in Dolphin for the upcoming stash:/ ioslave

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129044/#review99649
-----------------------------------------------------------



About the stash action, in what circumstances the action should be enabled/disabled?

I guess it should only be enabled if:
1. Split view isn't enabled (clicking on the stash action will open the stash folder in a split view)
2. Split view is enabled and one view container shows the stash folder (clicking on the stash action will close the stash folder)

In all other cases it should be disabled, right?


src/dolphintabpage.h (line 53)
<https://git.reviewboard.kde.org/r/129044/#comment67001>

    I don't like the additional boolean argument.
    
    Better add an `secondaryUrl` argument with a default value of `QUrl()`. If the `secondaryUrl` is valid it will be used for the new view, otherwise the url of the primary view will be used. Please also adjust the method description ;)
    
    Another solution would be do call `tabPage->activeViewContainer()->setUrl(stash url)` in DolphinMainWindow::toggleSplitStash().


- Emmanuel Pescosta


On Sept. 27, 2016, 11:19 a.m., arnav dhamija wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129044/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2016, 11:19 a.m.)
> 
> 
> Review request for Dolphin, Boudhayan Gupta, David Faure, and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> The [stash:/ ioslave](https://github.com/KDE/kio-stash) provides an easy and convenient way for saving the URLs of complicated selections of files. To make this feature more useful, there have been suggestions to have a dedicated shortcut and GUI button for accessing the ioslave in a Split window. This patch adds a QAction in the DolphinMainWindow class for this purpose. The shortcut is subject to change and is currently set as Ctrl+**S**tash. By default, the action is visible in the View menu and the Toolbar of Dolphin.
> 
> 
> Diffs
> -----
> 
>   src/dolphinmainwindow.h 7003e94 
>   src/dolphinmainwindow.cpp 4d97fc1 
>   src/dolphintabpage.h 9d18088 
>   src/dolphintabpage.cpp c674e1e 
>   src/dolphinui.rc f197af4 
> 
> Diff: https://git.reviewboard.kde.org/r/129044/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screenshot of the button in the toolbar
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/09/27/2cb91ab8-5693-4953-b067-1ded856dd622__Screenshot_20160927_144649.png
> 
> 
> Thanks,
> 
> arnav dhamija
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160929/5ba178fb/attachment.htm>