Review Request 129043: Single Instance Dolphin

[Emmanuel Pescosta]

> On Sept. 27, 2016, 1:05 p.m., Anthony Fieroni wrote:
> > src/main.cpp, line 105
> > <https://git.reviewboard.kde.org/r/129043/diff/1/?file=481324#file481324line105>
> >
> >     You can deal with KDBusService::Unique. Yes, it's need application restart to take effect but it's not much effort.
> 
> Fady Ghatas wrote:
>     - There is a scenario that I don't need myself but it may be essential for someone. Which is to have a single window for all browsing stuff and 1 or more windows for something like multimonitor setup. Using KDBusService::Unique won't allow this kind of behavior in the future. It's a theoretical assumption that I personally won't use ever, but it may be needed by someone.
>     - Is there any other issues? The option is right in the startup tab or should be moved ?
> 
> Anthony Fieroni wrote:
>     I still think this patch is much effort. You can add Emmanuel Pescostta as reviewer, but *my* advice is to use KDBusService::NoExitOnFailure to try find another running instance by DBus and just *shoot* command over it rather than starting new instance.

Yes, KDBusService is the way to go ;)
There we need to set the startup options to `Unique` and listen to the `activateRequested` and `openRequested` signal. 

About your assumption: yes we should definitely support multi-window scenarios, but all this should be done via DBus methods.


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129043/#review99578
-----------------------------------------------------------


On Sept. 27, 2016, 10:53 a.m., Fady Ghatas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129043/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2016, 10:53 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 183429
>     https://bugs.kde.org/show_bug.cgi?id=183429
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Allows only single window of dolphin. This can be activated in Configure Dolphin>Startup>Single Instance. Openning new folders externally will just create new tabs instead of new windows.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 069096814d5e0ce88aac8ad405755a839c5c4d49 
>   src/dolphinsinglewindow.h PRE-CREATION 
>   src/dolphinsinglewindow.cpp PRE-CREATION 
>   src/main.cpp 8987d351f058d5b02a67c982ca51c937edc89ecf 
>   src/settings/dolphin_generalsettings.kcfg 12f158541187bd8d8e1359c589c1c99be6ae07a8 
>   src/settings/startup/startupsettingspage.h 9bcc3113171bbef5b5fdae186254a5bbe383cec0 
>   src/settings/startup/startupsettingspage.cpp 6554493d8066ab6a67c2ed633655e7ff6aed1d89 
> 
> Diff: https://git.reviewboard.kde.org/r/129043/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Fady Ghatas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160928/19fc59a0/attachment.htm>