Review Request 128972: Properly check Shift toggling in DolphinRemoveAction

[Elvis Angelaccio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128972/
-----------------------------------------------------------

(Updated Sept. 21, 2016, 6:25 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin and Emmanuel Pescosta.


Changes
-------

Submitted with commit 3775ef19eaca057985b92cfa3716d3c3a1d22f0f by Elvis Angelaccio to branch Applications/16.08.


Bugs: 354301
    https://bugs.kde.org/show_bug.cgi?id=354301


Repository: dolphin


Description
-------

Documentation of `QGuiApplication::keyboardModifiers()` says:
>The current state is updated sychronously as the event queue is emptied of events that will spontaneously change the keyboard state (QEvent::KeyPress and QEvent::KeyRelease events).
It should be noted this may not reflect the actual keys held on the input device at the time of calling but rather the modifiers as last reported in one of the above events.

Since this method is called in DolphinContextMenu's keyPressEvent() and keyReleaseEvent(), the first time that `keyboardModifiers()` is called it doesn't report that shift has been pressed.

Replacing this method with `queryKeyboardModifiers()` does the job because the latter doesn't care about the event queue.

Another solution could be adding a `bool isShiftPressed` argument to DolphinRemoveAction::update() and setting it to true in keyPressEvent() and false in keyReleaseEvent(). The problem is that update() is called also in other places, so it would become quite ugly...


Diffs
-----

  src/dolphinremoveaction.cpp c91d74579d76a30c69a1654146ea676bc7eb8e01 

Diff: https://git.reviewboard.kde.org/r/128972/diff/


Testing
-------

Toggling Shift when the context menu is open now works as expected.


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160921/d146243e/attachment.htm>