Review Request 128946: Add Donate button to Dolphin

Elvis Angelaccio elvis.angelaccio at kde.org
Tue Sep 20 10:26:31 BST 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128946/
-----------------------------------------------------------

(Updated Sept. 20, 2016, 9:26 a.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin, Albert Astals Cid and Emmanuel Pescosta.


Changes
-------

Submitted with commit ca53974181c17234f4522bd1635d4c0ab4281e1d by Elvis Angelaccio to branch master.


Repository: dolphin


Description
-------

Dolphin has a custom "control" menu, so we need to manually add the new Donate standard action (see [[1]](https://quickgit.kde.org/?p=kxmlgui.git&a=commit&h=5ff477302d816d341f1a38009f74ac4ebb3214dd) and [[2]](https://git.reviewboard.kde.org/r/128609/)).

It seemed overkill to bump the KF5 minimum version to 5.26 only for these 2 lines of code, so the patch will only work if kconfigwidgets 5.26 is found at build time.


Diffs
-----

  src/dolphinmainwindow.cpp 34008b5eb685104d69f3b18b67affea2912dfcfc 

Diff: https://git.reviewboard.kde.org/r/128946/diff/


Testing
-------

Donate button is available in the Help submenu of the control menu.


File Attachments
----------------

Screenshot_20160817_214640.png
  https://git.reviewboard.kde.org/media/uploaded/files/2016/09/19/1c108dad-c7f2-4384-8676-640057cd80ee__Screenshot_20160817_214640.png


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160920/428bca08/attachment.htm>


More information about the kfm-devel mailing list