Review Request 128853: Drop unneeded RTL workaround

[Emmanuel Pescosta]

> On Sept. 20, 2016, 9:45 a.m., Emmanuel Pescosta wrote:
> > Thanks for the patch!
> > 
> > Why do you think that this is unneeded?
> > Isn't it the correct behavior in RTL mode when using the default shortcuts?
> > How do other applications with tabs behave in RTL mode?
> 
> Kai Uwe Broulik wrote:
>     QTabWidget layouts tabs from right to left in rtl mode, so "activate next tab" (ie. increasing the current index) will activate the tab *left* of it which is the correct behavior in this case.
>     
>     Patch makes sense imho.
> 
> Kai Uwe Broulik wrote:
>     Wait a secnd, I just noticed that while Dolphin tab widget aligns tabs on the right side, the order of tabs is still the same, so the first tab is the left-most one. It should be the other way round. Safa, can you check whether there's something else wrong / hardcoded in there?

Thanks for the info!

Dolphin uses the QTabWidget for the tab handling (addTab, setCurrentIndex, ...). 
So if QTabWidget has support for RTL it should work in Dolphin as well ;)
But I can't find anything about the RTL behavior of QTabWidget/QTabBar in the Qt documentation.


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128853/#review99293
-----------------------------------------------------------


On Sept. 7, 2016, 12:03 p.m., Safa Alfulaij wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128853/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2016, 12:03 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> The tab navigation shortcut workaround for RTL layouts is not needed anymore.
> RIght now, pressing Ctrl+Tab is making the **previous** tab (in RTL layout) the activated one, and vice versa.
> 
> 
> Diffs
> -----
> 
>   src/dolphinmainwindow.cpp 34008b5 
> 
> Diff: https://git.reviewboard.kde.org/r/128853/diff/
> 
> 
> Testing
> -------
> 
> Just by logic
> 
> 
> Thanks,
> 
> Safa Alfulaij
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160920/78d1948f/attachment.htm>