Review Request 128853: Drop unneeded RTL workaround

[Kai Uwe Broulik]

> On Sept. 20, 2016, 7:45 vorm., Emmanuel Pescosta wrote:
> > Thanks for the patch!
> > 
> > Why do you think that this is unneeded?
> > Isn't it the correct behavior in RTL mode when using the default shortcuts?
> > How do other applications with tabs behave in RTL mode?

QTabWidget layouts tabs from right to left in rtl mode, so "activate next tab" (ie. increasing the current index) will activate the tab *left* of it which is the correct behavior in this case.

Patch makes sense imho.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128853/#review99293
-----------------------------------------------------------


On Sept. 7, 2016, 10:03 vorm., Safa Alfulaij wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128853/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2016, 10:03 vorm.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> The tab navigation shortcut workaround for RTL layouts is not needed anymore.
> RIght now, pressing Ctrl+Tab is making the **previous** tab (in RTL layout) the activated one, and vice versa.
> 
> 
> Diffs
> -----
> 
>   src/dolphinmainwindow.cpp 34008b5 
> 
> Diff: https://git.reviewboard.kde.org/r/128853/diff/
> 
> 
> Testing
> -------
> 
> Just by logic
> 
> 
> Thanks,
> 
> Safa Alfulaij
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160920/1e0a506e/attachment.htm>