Review Request 128942: Partial implementation of Bug 358075. Added "Accessed" column, and renamed "Date" to "Modified" as requested by several tickets.

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128942/#review99279
-----------------------------------------------------------



Is the Accessed property useful when sorting by file type or opening the properties dialog? I think KIO reads the first few bytes of the file to determine the type.

- Christoph Feck


On Sept. 19, 2016, 6:42 a.m., Don Nguyen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128942/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2016, 6:42 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 358075
>     https://bugs.kde.org/show_bug.cgi?id=358075
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Several tickets want additional file time fields to be displayed such as creation time, access time, etc.   They also want "Date" to be renamed to something more meaningful.  What I've implemented was to add an "Accessed" column to show the file access time.  Creation time is not stored in Linux so displaying this is not possible.  I renamed the "Date" column to "Modified".  I implemented this in code by adding a new "accesstime" and AccessTimeRole to KFileItemsModel.  I changed the dateRoleGroups function to timeRoleGroups and it now takes a parameter to distinguish which type of time(access or modification) it's dealing with.  I also changed the DateRole enum to ModificationTimeRole so that it makes more sense with the new addition.  
> I am new to KDE and open source development.  This is my first attempt at working with ReviewBoard.
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kfileitemlistwidget.cpp 7e5b4bb 
>   src/kitemviews/kfileitemmodel.h 8a0df72 
>   src/kitemviews/kfileitemmodel.cpp 1f94972 
> 
> Diff: https://git.reviewboard.kde.org/r/128942/diff/
> 
> 
> Testing
> -------
> 
> Tested adding new "Accessed" column and verified data shown is correct.  Tested group sorting by Accessed time.  Tested "Modified" column still works as before when it was named "Date".
> 
> 
> File Attachments
> ----------------
> 
> screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/09/19/e5ceedf2-9534-484a-b343-f274702cf1e1__dolphinscreen
> 
> 
> Thanks,
> 
> Don Nguyen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160919/2b2c6696/attachment.htm>