Review Request 129083: [KIconLoader] Take into account devicePixelRatio for overlays
Emmanuel Pescosta
emmanuelpescosta099 at gmail.com
Fri Oct 28 12:40:42 BST 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129083/#review100354
-----------------------------------------------------------
src/kiconloader.cpp (line 514)
<https://git.reviewboard.kde.org/r/129083/#comment67358>
int -> qreal
src/kiconloader.cpp (line 516)
<https://git.reviewboard.kde.org/r/129083/#comment67357>
QPointF
- Emmanuel Pescosta
On Oct. 6, 2016, 10 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129083/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2016, 10 p.m.)
>
>
> Review request for Dolphin, KDE Frameworks and David Edmundson.
>
>
> Bugs: 369640
> https://bugs.kde.org/show_bug.cgi?id=369640
>
>
> Repository: kiconthemes
>
>
> Description
> -------
>
> Keeps them from being painted outside view and scales them with the image they're supposed to be painted on.
>
>
> Diffs
> -----
>
> src/kiconloader.cpp 5315ea4
>
> Diff: https://git.reviewboard.kde.org/r/129083/diff/
>
>
> Testing
> -------
>
> Ran dolphin with device pixel ratio 2, got my symolic link icon again.
> Ran it with device pixel ratio 1, looked as it did before.
>
> (couldn't figure out why the VCS icons don't show up though)
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161028/96658254/attachment.htm>
More information about the kfm-devel
mailing list