Review Request 129061: Don't hide not yet shown messagewidgets

[Elvis Angelaccio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129061/
-----------------------------------------------------------

(Updated Oct. 4, 2016, 3:24 p.m.)


Review request for Dolphin.


Changes
-------

New strategy: we introduce an explicit `reload()` method, as suggested by Emmanuel.


Bugs: 357651
    https://bugs.kde.org/show_bug.cgi?id=357651


Repository: dolphin


Description
-------

Bug #357651 results in a messagewidget that gets hidden before it's even shown. Since we already have a slot connected to the `directoryLoadingCompleted()` signal, we can use to it to check whether the message widget has finished the animated show (instead of connecting this signal to `KMessageWidget::hide`).


Diffs (updated)
-----

  src/dolphinmainwindow.cpp 34008b5 
  src/dolphinviewcontainer.h 62f9110 
  src/dolphinviewcontainer.cpp 1c43fc9 

Diff: https://git.reviewboard.kde.org/r/129061/diff/


Testing
-------

The messagewidget from bug #357651 is now visible. Refreshing the view still hides a visible messagewidget.


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161004/b7c341ee/attachment.htm>