Review Request 129094: [dolphin] Add text/plain mime data with urls in PrettyDecoded string format

[Alexandr Akulich]

> On Oct. 4, 2016, 7:09 p.m., Emmanuel Pescosta wrote:
> > Thanks for the patch!
> > 
> > This should be added to `KUrlMimeData::setUrls` instead.

I thought that the KUrlMimeData class can be used on Mime object with already exists custom text/plain data.
I can add a condition to add the text/plain only if it doesn't exist, will it be OK?


- Alexandr


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129094/#review99767
-----------------------------------------------------------


On Oct. 4, 2016, 7:04 p.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129094/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2016, 7:04 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Use case: copy file in Dolphin and paste its URL in Firefox
> 
> Some applications (such as QtCreator) are smart enough to use text/uri-list value, but, sadly, other applications (such as Firefox) accepts only text/plain
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kfileitemmodel.cpp 05f85a6 
> 
> Diff: https://git.reviewboard.kde.org/r/129094/diff/
> 
> 
> Testing
> -------
> 
> Now Ctrl+C on a file in Dolphin and Ctrl+V in the address line in Firefox works as expected.
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161004/beecb2e2/attachment.htm>