Review Request 129085: Popupmenu: use KIO's new addPluginActionsTo method

[David Faure]

> On Oct. 2, 2016, 7:27 p.m., Emmanuel Pescosta wrote:
> > Nice!
> > 
> > IMHO we should just increase the min. frameworks version and drop the conditional inclusion. The lesser conditional compiled code we have to maintain, the better :)

IMHO we should wait just a little bit, 5.27 isn't even released yet ;)

And even then, I'd wait a few months, to make it easier for the thousands of dolphin contributors that send you patches every day and use distro packages :-)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129085/#review99714
-----------------------------------------------------------


On Oct. 2, 2016, 7:10 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129085/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2016, 7:10 p.m.)
> 
> 
> Review request for Dolphin and Elvis Angelaccio.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Popupmenu: use KIO 5.27's new addPluginActionsTo method
> 
> 
> Diffs
> -----
> 
>   src/dolphincontextmenu.h 419d3f9bd4bd0c71fe9132c0299cb2381f399536 
>   src/dolphincontextmenu.cpp 971ef1e35fa1f4d64257067a10b3e6a18ccb14b3 
> 
> Diff: https://git.reviewboard.kde.org/r/129085/diff/
> 
> 
> Testing
> -------
> 
> Right-clicking, the plugins are still there ;)
> 
> It also still works with an older KIO, due to the version check.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161002/2d15ffb0/attachment.htm>