Review Request 129589: Avoid opening duplicate Properties dialogs

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129589/#review101184
-----------------------------------------------------------



I see no code to actually update the url of the property dialog when you want to show the properties of a different item than is already opened. Thinking of that, either the code should reuse an existing dialog _only_ if you try to open it again for the same item (which would need a map Url->dialog instance), or it should always update the url of the existing dialog. The downside is that you cnn no longer compare properties for different items side by side.

- Christoph Feck


On Nov. 30, 2016, 12:48 a.m., Mario Bereš wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129589/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2016, 12:48 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 372703
>     https://bugs.kde.org/show_bug.cgi?id=372703
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> You could open duplicate Properties dialogs because every time u hit "Properties" button, a new KPropertiesDialog is created. Now it's stored in class variable until it destroys, if you try to open another KPropertiesDialog it will focus back to already opened one.
> 
> 
> Diffs
> -----
> 
>   src/views/dolphinviewactionhandler.h eb375b5 
>   src/views/dolphinviewactionhandler.cpp 858f929 
> 
> Diff: https://git.reviewboard.kde.org/r/129589/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mario Bereš
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161130/e3ad468f/attachment.htm>