Review Request 129589: Avoid opening duplicate Properties dialogs
Mario Bereš
beriomario at gmail.com
Tue Nov 29 23:48:55 GMT 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129589/
-----------------------------------------------------------
(Updated Nov. 29, 2016, 11:48 p.m.)
Review request for Dolphin.
Changes
-------
Settled m_propertiesDialog initialization to class constructor.
Bugs: https://bugs.kde.org/show_bug.cgi?id=372703
https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=372703
Repository: dolphin
Description
-------
You could open duplicate Properties dialogs because every time u hit "Properties" button, a new KPropertiesDialog is created. Now it's stored in class variable until it destroys, if you try to open another KPropertiesDialog it will focus back to already opened one.
Diffs (updated)
-----
src/views/dolphinviewactionhandler.h eb375b5
src/views/dolphinviewactionhandler.cpp 858f929
Diff: https://git.reviewboard.kde.org/r/129589/diff/
Testing
-------
Thanks,
Mario Bereš
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161129/8e9ce589/attachment.htm>
More information about the kfm-devel
mailing list