Review Request 129533: expand all in tree view

[Thomas Pfeiffer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129533/#review101059
-----------------------------------------------------------



Nice feature, but having it accessible only via keyboard makes it quite hidden. Would it be possible to put it into the context menu of the tree's root, as well as providing a toolbar button for it (which would not be in the default toolbar but users could add it manually)?
Also, using a shortcut without a modifier would be very non-standard.

- Thomas Pfeiffer


On Nov. 22, 2016, 8:04 p.m., Don Nguyen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129533/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2016, 8:04 p.m.)
> 
> 
> Review request for Dolphin and KDE Usability.
> 
> 
> Bugs: 196772
>     https://bugs.kde.org/show_bug.cgi?id=196772
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This allows the user to expand all expandable items in tree view by pressing '*'.  I've implemented this by adding expandAll() to the model, which is similar to QTreeView::expandAll(). The screenshots demonstrates the results after each press of '*'.  
> 
> Later, I can implement collapseAll() similarly, as well as the ability to expand selected folders if someone wants to tell me how those functionalities should be exposed (e.g., via menus or keypresses).
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kfileitemmodel.h 8a0df72 
>   src/kitemviews/kfileitemmodel.cpp 05f85a6 
>   src/kitemviews/kitemlistcontroller.cpp 1c86ff0 
>   src/kitemviews/kitemmodelbase.h bd5ca1d 
>   src/kitemviews/kitemmodelbase.cpp bf41b1c 
> 
> Diff: https://git.reviewboard.kde.org/r/129533/diff/
> 
> 
> Testing
> -------
> 
> manual testing, and make test passes
> 
> 
> File Attachments
> ----------------
> 
> screen1
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/11/22/a976337d-1537-40ca-97e4-925e8b603654__snapshot1.png
> screen2
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/11/22/b671f80a-455c-455c-8aa1-f1959a6d0c8b__snapshot2.png
> screen3
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/11/22/4a3770e9-7134-4d26-a5be-c66168a80252__snapshot3.png
> screen4
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/11/22/fe8a3788-f9ef-48bd-ba12-352a96e7de7b__snapshot4.png
> 
> 
> Thanks,
> 
> Don Nguyen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161122/962f8c71/attachment.htm>