Review Request 129141: [search] Reload search view when file is deleted or copied

[Emmanuel Pescosta]

> On Nov. 20, 2016, 9:17 p.m., David Faure wrote:
> > src/kitemviews/kfileitemmodel.cpp, line 123
> > <https://git.reviewboard.kde.org/r/129141/diff/2/?file=485646#file485646line123>
> >
> >     KDirLister::Keep was meant to be used for tree views, where listing a subdir shouldn't forget about the parent dir, it's still shown.
> >     
> >     (while in an icon view or detailed list view, going to a different directory means we're not showing the previous directory anymore).
> >     
> >     If this model can do both trees and lists, maybe the use of Keep should be conditional?

> If this model can do both trees and lists, maybe the use of Keep should be conditional?

This is already implemented, see https://github.com/KDE/dolphin/blob/master/src/kitemviews/kfileitemmodel.cpp#L514


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129141/#review100978
-----------------------------------------------------------


On Nov. 16, 2016, 9:40 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129141/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2016, 9:40 p.m.)
> 
> 
> Review request for Dolphin, David Faure and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> I'm not sure it is correct to use KDirLister::Keep
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kfileitemmodel.cpp 05f85a6 
> 
> Diff: https://git.reviewboard.kde.org/r/129141/diff/
> 
> 
> Testing
> -------
> 
> Delete / create work. KDirLister::Keep should use only in search mode (filenamesearch or baloosearch) ?
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161120/f3a0ad22/attachment.htm>