Review Request 129044: Adding a dedicated Stash action button in Dolphin for the upcoming stash:/ ioslave

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129044/#review100960
-----------------------------------------------------------



Currently the state of the stash view is shared between the action (check/unchecked) and the tab page, this may lead to some problems in future.
I think it would be better if only the tab page keeps the state, the "visual state" of action is adjusted by updateSplitAction depending on the state of the tab page (same as the normal split action) and also toggleSplitStash should just use the state of the tab page to decide if split view has to be enabled or disabled.


src/dolphinmainwindow.h 
<https://git.reviewboard.kde.org/r/129044/#comment67710>

    Please remove all unrelated changes in the whole diff



src/dolphinmainwindow.cpp (lines 531 - 532)
<https://git.reviewboard.kde.org/r/129044/#comment67712>

    remove



src/dolphinmainwindow.cpp (line 536)
<https://git.reviewboard.kde.org/r/129044/#comment67714>

    the action is already checked



src/dolphinmainwindow.cpp (line 538)
<https://git.reviewboard.kde.org/r/129044/#comment67713>

    You need to check which view shows the stash folder, active it and then disable the split view (the active view will be closed if split view gets disabled).



src/dolphinmainwindow.cpp (line 1483)
<https://git.reviewboard.kde.org/r/129044/#comment67711>

    In this case you need to check if any of the views shows the stash folder and enable/disable the stash action accordingly.



src/dolphintabpage.cpp (line 74)
<https://git.reviewboard.kde.org/r/129044/#comment67709>

    Please remove the "= QUrl()" to avoid duplication of information, otherwise this may lead to confusions if the default value changes without adjusting this comment.


- Emmanuel Pescosta


On Nov. 3, 2016, 5:09 a.m., arnav dhamija wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129044/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2016, 5:09 a.m.)
> 
> 
> Review request for Dolphin, Boudhayan Gupta, David Faure, and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> The [stash:/ ioslave](https://github.com/KDE/kio-stash) provides an easy and convenient way for saving the URLs of complicated selections of files. To make this feature more useful, there have been suggestions to have a dedicated shortcut and GUI button for accessing the ioslave in a Split window. This patch adds a QAction in the DolphinMainWindow class for this purpose. The shortcut is subject to change and is currently set as Ctrl+**S**tash. By default, the action is visible in the View menu and the Toolbar of Dolphin.
> 
> 
> Diffs
> -----
> 
>   src/dolphinmainwindow.h 7003e94 
>   src/dolphinmainwindow.cpp 4d97fc1 
>   src/dolphintabpage.h 9d18088 
>   src/dolphintabpage.cpp c674e1e 
>   src/dolphinui.rc f197af4 
> 
> Diff: https://git.reviewboard.kde.org/r/129044/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screenshot of the button in the toolbar
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/09/27/2cb91ab8-5693-4953-b067-1ded856dd622__Screenshot_20160927_144649.png
> 
> 
> Thanks,
> 
> arnav dhamija
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161120/2fd0a829/attachment.htm>