Review Request 129077: Merge of requests: #128964 and #128942 - Change "Date" to "Modified" and allow access to new "Accessed" time field

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Sun Nov 20 10:56:13 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129077/#review100959
-----------------------------------------------------------


Ship it!




Looks good! Thanks!

Please commit it to master.
The gitignore changes should go into another commit pls.

- Emmanuel Pescosta


On Nov. 17, 2016, 6:07 p.m., Don Nguyen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129077/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2016, 6:07 p.m.)
> 
> 
> Review request for Dolphin and Emmanuel Pescosta.
> 
> 
> Bugs: 358075
>     https://bugs.kde.org/show_bug.cgi?id=358075
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This is merge of #128964 and #128942.  This will impelement changing the "Date" field to "Modified" and allow a new "Accessed" time field to be available.  This also includes changes to update configuration files.  
> The extra .gitignore just contains a few entries that I think we should have.  Other repositories have them.
> 
> 
> Diffs
> -----
> 
>   .gitignore PRE-CREATION 
>   src/kitemviews/kfileitemlistwidget.cpp 7e5b4bb 
>   src/kitemviews/kfileitemmodel.h 8a0df72 
>   src/kitemviews/kfileitemmodel.cpp 05f85a6 
>   src/panels/places/placesitemmodel.cpp 25c4d51 
>   src/settings/viewpropertiesdialog.cpp 7407042 
>   src/tests/kfileitemmodeltest.cpp 6c45e11 
>   src/views/viewproperties.h dc118e2 
>   src/views/viewproperties.cpp 597baa2 
> 
> Diff: https://git.reviewboard.kde.org/r/129077/diff/
> 
> 
> Testing
> -------
> 
> As mentioned in #128964 and #128942
> 
> 
> File Attachments
> ----------------
> 
> screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/11/17/cf8408a8-f888-48ad-bd18-73f763d699a6__dolphinscreen.png
> 
> 
> Thanks,
> 
> Don Nguyen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161120/48f81b51/attachment.htm>


More information about the kfm-devel mailing list