Review Request 129409: Fix scrolling in dock panels

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129409/#review100958
-----------------------------------------------------------


Fix it, then Ship it!




Looks good otherwise!


src/kitemviews/kitemlistview.h (line 161)
<https://git.reviewboard.kde.org/r/129409/#comment67708>

    Docs please



src/kitemviews/private/kitemlistsizehintresolver.h (line 39)
<https://git.reviewboard.kde.org/r/129409/#comment67706>

    I think that this method should be named maxSizeHint instead



src/kitemviews/private/kitemlistsizehintresolver.cpp (line 160)
<https://git.reviewboard.kde.org/r/129409/#comment67707>

    This will break if m_logicalHeightHintCache is empty. Please check it and maybe assign 0.0 instead


- Emmanuel Pescosta


On Nov. 20, 2016, 11:33 a.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129409/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2016, 11:33 a.m.)
> 
> 
> Review request for Dolphin, Emmanuel Pescosta and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Bugs: 365968
>     https://bugs.kde.org/show_bug.cgi?id=365968
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> The reason why scrolling is smooth in the DolphinView but not in the dock panels is: https://bugs.kde.org/show_bug.cgi?id=365968#c19
> 
> This patch changes KItemListContainer::updateScrollOffsetScrollBar() to use a new KItemListView::itemSizeHint() method which adapts to the current icon size in the panels. This ensures the scroll is always smooth in both main and dock panels.
> 
> BUG: 365968
> FIXED-IN: 16.12.0
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kitemlistcontainer.cpp 6974ebb 
>   src/kitemviews/kitemlistview.h 9adf9f8 
>   src/kitemviews/kitemlistview.cpp df65399 
>   src/kitemviews/private/kitemlistsizehintresolver.h ff17f2d 
>   src/kitemviews/private/kitemlistsizehintresolver.cpp 1d80670 
> 
> Diff: https://git.reviewboard.kde.org/r/129409/diff/
> 
> 
> Testing
> -------
> 
> Scroll is now smoot both in Places and Folders dock panels. Tested with xf86-input-libinput and xf86-input-evded drivers, and libinput on Wayland.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161120/9f11a9ce/attachment.htm>