Review Request 129409: Fix scrolling in dock panels

Elvis Angelaccio elvis.angelaccio at kde.org
Tue Nov 15 16:13:37 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129409/
-----------------------------------------------------------

(Updated Nov. 15, 2016, 4:13 p.m.)


Review request for Dolphin, Emmanuel Pescosta and Martin Tobias Holmedahl Sandsmark.


Bugs: 365968
    https://bugs.kde.org/show_bug.cgi?id=365968


Repository: dolphin


Description (updated)
-------

The reason why scrolling is smooth in the DolphinView but not in the dock panels is: https://bugs.kde.org/show_bug.cgi?id=365968#c19

So we just need to set a default itemSize in the KStandardItemListView constructor.
The itemHeight is computed like in DolphinItemListView::updateGridSize().


Diffs
-----

  src/kitemviews/kstandarditemlistview.cpp 6471002c72f7a854b54d653f5248939a7861a225 

Diff: https://git.reviewboard.kde.org/r/129409/diff/


Testing
-------

Scroll is now smoot both in Places and Folders dock panels (with xorg-libinput). Not tested yet with xorg-evdev but it shouldn't make a difference.


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161115/58b751e6/attachment.htm>


More information about the kfm-devel mailing list