Review Request 129334: One line bug in KItemListWidget.cpp

[Don Nguyen]

> On Nov. 4, 2016, 8:36 p.m., Christoph Feck wrote:
> > src/kitemviews/kitemlistwidget.cpp, line 183
> > <https://git.reviewboard.kde.org/r/129334/diff/1/?file=484068#file484068line183>
> >
> >     I would suggest moving this before the if, so that (the "expensive") .value() isn't called twice.

Good suggestion!  Thanks.


- Don


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129334/#review100577
-----------------------------------------------------------


On Nov. 4, 2016, 8:29 p.m., Don Nguyen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129334/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2016, 8:29 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> previousWidth was set incorrectly.  since this variable isn't currently being used, it doesn't affect anything, but if someone tries to use it in the future, it would be incorrect.
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kitemlistwidget.cpp 9c31155 
> 
> Diff: https://git.reviewboard.kde.org/r/129334/diff/
> 
> 
> Testing
> -------
> 
> I tested it with the debugger to verify that the function that accepts this value (colunnWidthChanged) now gets the correct value (even tho it doesn't use it).
> 
> 
> Thanks,
> 
> Don Nguyen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161104/f43a51a4/attachment.htm>