Review Request 127930: Fix crash when closing split view with ownCloud plugin loaded

[Martin Tobias Holmedahl Sandsmark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127930/
-----------------------------------------------------------

(Updated May 21, 2016, 4:12 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin, Emmanuel Pescosta, Michael Pyne, and Olivier Goffart.


Changes
-------

Submitted with commit b1471bbd09d88da3ffe8159075b3108bf9586220 by Martin T. H. Sandsmark to branch master.


Bugs: 357479
    https://bugs.kde.org/show_bug.cgi?id=357479


Repository: dolphin


Description
-------

KPluginLoader::instantiatePlugins() wraps QPluginLoader::instance(),
which doesn't return a new object for each call, so if we set the 
KFileItemModelRolesUpdater instance as parent to the plugin the shared
instance will be deleted leading to crashes when other instances of
KFileItemModelRolesUpdater tries to use their plugin objects.

To fix this, set the QApplication as a parent.

BUG: 357479


Diffs
-----

  src/kitemviews/kfileitemmodelrolesupdater.cpp e5353dc 

Diff: https://git.reviewboard.kde.org/r/127930/diff/


Testing
-------

Yes.


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160521/f33adaf4/attachment.htm>