Review Request 127902: [git plugin] Show local changes action

Anthony Fieroni bvbfan at abv.bg
Wed May 18 18:22:35 BST 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127902/
-----------------------------------------------------------

(Updated May 18, 2016, 5:22 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin and Emmanuel Pescosta.


Changes
-------

Submitted with commit 713625e4106196de66068f7ba5aafa9a5768f700 by Anthony Fieroni to branch master.


Repository: dolphin-plugins


Description
-------

Show Local Git Changes looks ugly, but QProcess::startDetached(bash, -c git diff . | kompare-, fullpath) and git --git-dir=fullpath.git are even more uglier.


Diffs
-----

  git/fileviewgitplugin.h 3148b12 
  git/fileviewgitplugin.cpp 8abc618 

Diff: https://git.reviewboard.kde.org/r/127902/diff/


Testing
-------


Thanks,

Anthony Fieroni

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160518/a2306ab6/attachment.htm>


More information about the kfm-devel mailing list