Review Request 127951: Don't allow opening the terminal if shell_access Kiosk mode is set

[David Edmundson]

> On May 18, 2016, 6:08 a.m., Emmanuel Pescosta wrote:
> > LGTM
> > 
> > Please note that there is also a service action to open the terminal. 
> > Can you please check if this service action is locked down as well? Thanks!

Opening the terminal should be already blocked. As it will be be executed via krun and either be squashed there or by kinit.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127951/#review95569
-----------------------------------------------------------


On May 18, 2016, 9:12 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127951/
> -----------------------------------------------------------
> 
> (Updated May 18, 2016, 9:12 a.m.)
> 
> 
> Review request for Dolphin and Kai Uwe Broulik.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Don't allow opening the terminal if shell_access Kiosk mode is set
> 
> DolphinPart already did this. Dolphin itself didn't have this feature.
> 
> 
> Diffs
> -----
> 
>   src/dolphinmainwindow.cpp d4f2b06e75075b69ade4a40b59721d6ea818ffea 
>   src/dolphinpart.cpp 01fe207f30909f02d9abab8f94c80dd52273db1c 
> 
> Diff: https://git.reviewboard.kde.org/r/127951/diff/
> 
> 
> Testing
> -------
> 
> Set 
> 
> /etc/kde5rc to:
> 
> [KDE Action Restrictions][$i]
> shell_access=false
> action/shell_access=false
> 
> 
> could no longer open konsole
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160518/447bdba6/attachment.htm>