Review Request 127877: use the "selected" icon state for the selected sidebar item

Marco Martin notmart at gmail.com
Tue May 10 12:21:38 BST 2016



> On May 10, 2016, 7:01 a.m., Emmanuel Pescosta wrote:
> > src/kitemviews/kstandarditemlistwidget.cpp, lines 327-331
> > <https://git.reviewboard.kde.org/r/127877/diff/1/?file=464539#file464539line327>
> >
> >     QWindowStateChangeEvent?

that doesn't seem to work (not passed to QGraphicsWidgets i guess) but WindowActivate/WindowDeactivate does


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127877/#review95321
-----------------------------------------------------------


On May 10, 2016, 11:21 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127877/
> -----------------------------------------------------------
> 
> (Updated May 10, 2016, 11:21 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Since now the breeze icons can be recolored by kiconloader with svg stylesheets, use this feature to recolor the currently selected icon in the sidebar and in the details view (not the icon view)
> look wouldn't change if used with icon themes that don't support this feature
> This makes it look more in line with the breeze style
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kstandarditemlistwidget.h 9ab5d4c 
>   src/kitemviews/kstandarditemlistwidget.cpp 51c5bc8 
> 
> Diff: https://git.reviewboard.kde.org/r/127877/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> menu1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/7de5daff-35f3-41f5-a8d0-5097e5e1c4b4__menu1.png
> menu2.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/98bd3b3c-b387-4ff8-9eb8-c2e1a752b528__menu2.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160510/42fda564/attachment.htm>


More information about the kfm-devel mailing list