Review Request 127877: use the "selected" icon state for the selected sidebar item

Andreas Kainz kainz.a at gmail.com
Mon May 9 23:22:27 BST 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127877/#review95313
-----------------------------------------------------------


Ship it!




I can't review the code but this is one of the best features in the past 2 years

- Andreas Kainz


On Mai 9, 2016, 4:14 nachm., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127877/
> -----------------------------------------------------------
> 
> (Updated Mai 9, 2016, 4:14 nachm.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Since now the breeze icons can be recolored by kiconloader with svg stylesheets, use this feature to recolor the currently selected icon in the sidebar and in the details view (not the icon view)
> look wouldn't change if used with icon themes that don't support this feature
> This makes it look more in line with the breeze style
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kstandarditemlistwidget.h 9ab5d4c 
>   src/kitemviews/kstandarditemlistwidget.cpp 51c5bc8 
> 
> Diff: https://git.reviewboard.kde.org/r/127877/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> menu1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/7de5daff-35f3-41f5-a8d0-5097e5e1c4b4__menu1.png
> menu2.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/98bd3b3c-b387-4ff8-9eb8-c2e1a752b528__menu2.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160509/15f03947/attachment.htm>


More information about the kfm-devel mailing list