Review Request 127799: Fix missing audio duration in details view

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127799/#review95066
-----------------------------------------------------------




src/kitemviews/private/kbaloorolesprovider.cpp (line 184)
<https://git.reviewboard.kde.org/r/127799/#comment64518>

    Shouldn't it be the same with this?
    `QTime duration(0, 0, value);`


- Aleix Pol Gonzalez


On May 1, 2016, midnight, Marc André Wittorf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127799/
> -----------------------------------------------------------
> 
> (Updated May 1, 2016, midnight)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Enabling the 'duration' column in a folder with audio files did only show empty information. Properly initializing the QTime object fixes this.
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/private/kbaloorolesprovider.cpp e0b889e 
> 
> Diff: https://git.reviewboard.kde.org/r/127799/diff/
> 
> 
> Testing
> -------
> 
> 1. Find a folder with audio files
> 2. Make sure that Baloo has indexed this folder
> 3. Open this folder in Dolphin, detail view, enable the Audio/Duration column
> 4. Unpatched Dolphin does not display audio duration, patched Dolphin does
> 
> Tested on Gentoo x86_64 with Qt 5.5.1, KF 5.21.0 and Arch x86_64 with Qt 5.6.0 and KF 5.21.0.
> 
> 
> Thanks,
> 
> Marc André Wittorf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160501/32c154e9/attachment.htm>