[KDE Usability] Review Request 127054: Add a Filter Toolbar Button for Dolphin

[Emmanuel Pescosta]

> On March 25, 2016, 8:43 a.m., Emmanuel Pescosta wrote:
> > dolphinmainwindow.cpp, lines 1484-1494
> > <https://git.reviewboard.kde.org/r/127054/diff/11/?file=453601#file453601line1484>
> >
> >     I still think that we should put this into a new object. 
> >     
> >     1. We can avoid the object == action("name") check
> >     2. We can reuse it outside of the main window
> 
> arnav dhamija wrote:
>     I am not able to understand how this would avoid the object == action("name") check? I did go through the KDE paste which you made about a week ago, but I'm afraid there are many concepts I do not understand in it. If possible, I would be very happy to speak to you on IRC to resolve my doubts.

> If possible, I would be very happy to speak to you on IRC to resolve my doubts.

Yes for sure! I'm currently traveling home by train (bad connection ...), but this evening (UTC/Vienna) or tomorrow? 
You can also ping me on hangout when you are online and have some time ;)


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127054/#review93958
-----------------------------------------------------------


On March 19, 2016, 5:04 a.m., arnav dhamija wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127054/
> -----------------------------------------------------------
> 
> (Updated March 19, 2016, 5:04 a.m.)
> 
> 
> Review request for Dolphin, KDE Usability and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This patch was created to implement the feature suggested here: [https://todo.kde.org/?controller=task&action=show&task_id=966](https://todo.kde.org/?controller=task&action=show&task_id=966)
> 
> This patch adds a Filter Button to the toolbar of Dolphin. This button can be toggled to show/hide the Filter Bar.
> 
> In this patch, one might notice that there is now show_filter_bar and show_filter_bar_button in dolphinui.rc file. This was done because I found that using the same action for the menu entry and the toolbar entry would cause something to break (eg, shortcuts would stop working). 
> 
> A screenshot of the toolbar is also attached.
> 
> 
> Diffs
> -----
> 
>   dolphinmainwindow.h 7003e94 
>   dolphinmainwindow.cpp f7a7613 
>   dolphinviewcontainer.h 62f9110 
>   dolphinviewcontainer.cpp 8fea3ba 
> 
> Diff: https://git.reviewboard.kde.org/r/127054/diff/
> 
> 
> Testing
> -------
> 
> manual
> 
> 
> File Attachments
> ----------------
> 
> dolphintoolbar.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/12/d936e5d0-557c-45c5-9a2d-f849e5d284a6__dolphintoolbar.png
> 
> 
> Thanks,
> 
> arnav dhamija
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160325/181b3110/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-usability mailing list
kde-usability at kde.org
https://mail.kde.org/mailman/listinfo/kde-usability