[KDE Usability] Review Request 127034: Close tab on mouse release

[Emmanuel Pescosta]

> On Feb. 10, 2016, 10:52 p.m., Frank Reininghaus wrote:
> > Makes sense, but I'm wondering if we should check if the tab where the button is released is also the one where the button was pressed. Other apps seem to do this (i.e., they do not close a tab if you middle-click somewhere outside the tab, move the mouse to the tab, and then release).

> but I'm wondering if we should check if the tab where the button is released is also the one where the button was pressed

+1 from my side


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127034/#review92244
-----------------------------------------------------------


On Feb. 10, 2016, 10:38 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127034/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 10:38 p.m.)
> 
> 
> Review request for Dolphin and KDE Usability.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> rather than on mouse press.
> 
> 
> Diffs
> -----
> 
>   src/dolphintabbar.h 6daa9a1 
>   src/dolphintabbar.cpp dbd324d 
> 
> Diff: https://git.reviewboard.kde.org/r/127034/diff/
> 
> 
> Testing
> -------
> 
> I've always wondered why closing tabs in Dolphin felt so weird compared to other applications, now I know why.
> 
> Makes it consistent with other applications, namely web browsers, also button presses are also usually handled on release.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160316/fc60ea64/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-usability mailing list
kde-usability at kde.org
https://mail.kde.org/mailman/listinfo/kde-usability