[KDE Usability] Review Request 127054: Add a Filter Toolbar Button for Dolphin

[Thomas Pfeiffer]

> On Feb. 12, 2016, 3:07 p.m., Kai Uwe Broulik wrote:
> > While I think it's a great idea to have a ToolButton for this I don't think it should be there by default
> 
> arnav dhamija wrote:
>     What are the downsides to having this Filter toolbar button as a default option?
> 
> Thomas Pfeiffer wrote:
>     The downside is that it makes the user interface more complex, as users will have to decide whether they want to search or filter.
>     Please do not show the button by default.
> 
> arnav dhamija wrote:
>     Should this option to show the button be in the conventional general settings menu or in the ["Configure Toolbars"](http://i.imgur.com/jo1mKvS.png) window?

It belongs in Configure Toolbars like any other toolbar button.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127054/#review92300
-----------------------------------------------------------


On March 13, 2016, 9:53 a.m., arnav dhamija wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127054/
> -----------------------------------------------------------
> 
> (Updated March 13, 2016, 9:53 a.m.)
> 
> 
> Review request for Dolphin, KDE Usability and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This patch was created to implement the feature suggested here: [https://todo.kde.org/?controller=task&action=show&task_id=966](https://todo.kde.org/?controller=task&action=show&task_id=966)
> 
> This patch adds a Filter Button to the toolbar of Dolphin. This button can be toggled to show/hide the Filter Bar.
> 
> In this patch, one might notice that there is now show_filter_bar and show_filter_bar_button in dolphinui.rc file. This was done because I found that using the same action for the menu entry and the toolbar entry would cause something to break (eg, shortcuts would stop working). 
> 
> A screenshot of the toolbar is also attached.
> 
> 
> Diffs
> -----
> 
>   dolphinmainwindow.h 7003e94 
>   dolphinmainwindow.cpp f7a7613 
>   dolphinui.rc f197af4 
> 
> Diff: https://git.reviewboard.kde.org/r/127054/diff/
> 
> 
> Testing
> -------
> 
> manual
> 
> 
> File Attachments
> ----------------
> 
> dolphintoolbar.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/12/d936e5d0-557c-45c5-9a2d-f849e5d284a6__dolphintoolbar.png
> 
> 
> Thanks,
> 
> arnav dhamija
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160313/8af4b386/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-usability mailing list
kde-usability at kde.org
https://mail.kde.org/mailman/listinfo/kde-usability