[KDE Usability] Review Request 127054: Add a Filter Toolbar Button for Dolphin

[arnav dhamija]

> On March 12, 2016, 11:10 p.m., Thomas Lübking wrote:
> > dolphinmainwindow.cpp, line 1092
> > <https://git.reviewboard.kde.org/r/127054/diff/4/?file=449843#file449843line1092>
> >
> >     What exactly was the problem with
> >     
> >     QAction *showFilterBar ...;
> >     showFilterBar->setCheckable(true);
> >     ?

Right. So the problem with the QAction is that it doesn't have a "Pressed" state when the Filter button has been toggled. QPushButton probably would support do it but the rest of the Toggle buttons in the Dolphin Toolbar also use a KToggleAction (eg the Preview button) so I felt this approach makes more sense.


> On March 12, 2016, 11:10 p.m., Thomas Lübking wrote:
> > dolphinmainwindow.cpp, line 547
> > <https://git.reviewboard.kde.org/r/127054/diff/4/?file=449843#file449843line547>
> >
> >     This does not cover the case of the shortcut being invoked while the filterbar is visible, but does not have the focus - afaics, in that case the focus should move there and only on a third invocation, the filterbar be hidden to preserve present behavior itr)
> >     
> >     for this, you'll have to override the virtual ::event(QEvent), check whether the events type is QEvent::Shortcut, statically cast the event and match the keysequence to the one assigned to the action.
> >     If it matches *exactly*, the next relevant *trigger* signal is caused by the shortcut (in which case you want to apply the special handling)
> >     
> >     Should be enough task for a sunday? ;-)
> >     If you get stuck, ask =)

I just tested it by unfocussing the Filter bar. Shortcuts still seem to work okay! Unless there is some other case I haven't understood where it won't work?

But I realised that using a KToggleAction has some severe conseuqences - Dolphin will crash if the Split view button is pressed while the Filter Bar is active. Going back to a QAction stops Dolphin from crashing but it does not give the desired action of the button being depressed when the file manager is active.


- arnav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127054/#review93458
-----------------------------------------------------------


On March 12, 2016, 7:11 p.m., arnav dhamija wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127054/
> -----------------------------------------------------------
> 
> (Updated March 12, 2016, 7:11 p.m.)
> 
> 
> Review request for Dolphin, KDE Usability and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This patch was created to implement the feature suggested here: [https://todo.kde.org/?controller=task&action=show&task_id=966](https://todo.kde.org/?controller=task&action=show&task_id=966)
> 
> This patch adds a Filter Button to the toolbar of Dolphin. This button can be toggled to show/hide the Filter Bar.
> 
> In this patch, one might notice that there is now show_filter_bar and show_filter_bar_button in dolphinui.rc file. This was done because I found that using the same action for the menu entry and the toolbar entry would cause something to break (eg, shortcuts would stop working). 
> 
> A screenshot of the toolbar is also attached.
> 
> 
> Diffs
> -----
> 
>   dolphinmainwindow.h 7003e94 
>   dolphinmainwindow.cpp f7a7613 
>   dolphinui.rc f197af4 
> 
> Diff: https://git.reviewboard.kde.org/r/127054/diff/
> 
> 
> Testing
> -------
> 
> manual
> 
> 
> File Attachments
> ----------------
> 
> dolphintoolbar.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/12/d936e5d0-557c-45c5-9a2d-f849e5d284a6__dolphintoolbar.png
> 
> 
> Thanks,
> 
> arnav dhamija
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160313/f45d8dca/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-usability mailing list
kde-usability at kde.org
https://mail.kde.org/mailman/listinfo/kde-usability