[KDE Usability] Review Request 127054: Add a Filter Toolbar Button for Dolphin

[arnav dhamija]

> On March 12, 2016, 10:09 a.m., Emmanuel Pescosta wrote:
> >

Thanks for the review! I have made all the requested changes.


> On March 12, 2016, 10:09 a.m., Emmanuel Pescosta wrote:
> > dolphinmainwindow.cpp, lines 547-552
> > <https://git.reviewboard.kde.org/r/127054/diff/3/?file=449769#file449769line547>
> >
> >     Please use 4 spaces for indentation.
> >     
> >     Coding-Style is like this:
> >     if (...) {
> >         ...
> >     } else {
> >         ...
> >     }
> >     
> >     But you can avoid the if statement by just inverting the current visibility state: setVisible(!isVisible())

Yeah sorry about that, I agree it was pretty sloppy.


- arnav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127054/#review93436
-----------------------------------------------------------


On March 12, 2016, 8:14 a.m., arnav dhamija wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127054/
> -----------------------------------------------------------
> 
> (Updated March 12, 2016, 8:14 a.m.)
> 
> 
> Review request for Dolphin, KDE Usability and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This patch was created to implement the feature suggested here: [https://todo.kde.org/?controller=task&action=show&task_id=966](https://todo.kde.org/?controller=task&action=show&task_id=966)
> 
> This patch adds a Filter Button to the toolbar of Dolphin. This button can be toggled to show/hide the Filter Bar.
> 
> In this patch, one might notice that there is now show_filter_bar and show_filter_bar_button in dolphinui.rc file. This was done because I found that using the same action for the menu entry and the toolbar entry would cause something to break (eg, shortcuts would stop working). 
> 
> A screenshot of the toolbar is also attached.
> 
> 
> Diffs
> -----
> 
>   dolphinmainwindow.h 7003e94 
>   dolphinmainwindow.cpp f7a7613 
>   dolphinui.rc f197af4 
> 
> Diff: https://git.reviewboard.kde.org/r/127054/diff/
> 
> 
> Testing
> -------
> 
> manual
> 
> 
> File Attachments
> ----------------
> 
> dolphintoolbar.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/12/d936e5d0-557c-45c5-9a2d-f849e5d284a6__dolphintoolbar.png
> 
> 
> Thanks,
> 
> arnav dhamija
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160312/833fd592/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-usability mailing list
kde-usability at kde.org
https://mail.kde.org/mailman/listinfo/kde-usability