[KDE Usability] Review Request 127054: Add a Filter Toolbar Button for Dolphin

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127054/#review93435
-----------------------------------------------------------



Hi Arnav,
thanks for the patch :)
and sorry for the late reply!

There was an interesting post on the forum about making find a toggle button (which
makes a lot of sense IMHO). The post [1] was about the consequences of the toggle
button in respect of the shortcut behavior (focus handling). I think that the same 
applies to the filter toolbar as well. What do you think?

The possible states for the shortcut handling would be:
* toolbar hidden -> Strg+I -> toolbar visible+focus
* toolbar visible+focus -> Strg+I -> toolbar hidden
* toolbar visible -> Strg+I -> toolbar visible+focus

We need the same solution for the patch [2].

Otherwise your patch looks really good already!

[1] https://forum.kde.org/viewtopic.php?f=285&t=127215#p337843
[2] https://git.reviewboard.kde.org/r/107016/

- Emmanuel Pescosta


On March 12, 2016, 9:14 a.m., arnav dhamija wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127054/
> -----------------------------------------------------------
> 
> (Updated March 12, 2016, 9:14 a.m.)
> 
> 
> Review request for Dolphin, KDE Usability and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This patch was created to implement the feature suggested here: [https://todo.kde.org/?controller=task&action=show&task_id=966](https://todo.kde.org/?controller=task&action=show&task_id=966)
> 
> This patch adds a Filter Button to the toolbar of Dolphin. This button can be toggled to show/hide the Filter Bar.
> 
> In this patch, one might notice that there is now show_filter_bar and show_filter_bar_button in dolphinui.rc file. This was done because I found that using the same action for the menu entry and the toolbar entry would cause something to break (eg, shortcuts would stop working). 
> 
> A screenshot of the toolbar is also attached.
> 
> 
> Diffs
> -----
> 
>   dolphinmainwindow.h 7003e94 
>   dolphinmainwindow.cpp f7a7613 
>   dolphinui.rc f197af4 
> 
> Diff: https://git.reviewboard.kde.org/r/127054/diff/
> 
> 
> Testing
> -------
> 
> manual
> 
> 
> File Attachments
> ----------------
> 
> dolphintoolbar.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/12/d936e5d0-557c-45c5-9a2d-f849e5d284a6__dolphintoolbar.png
> 
> 
> Thanks,
> 
> arnav dhamija
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160312/d71f9d0a/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-usability mailing list
kde-usability at kde.org
https://mail.kde.org/mailman/listinfo/kde-usability