[KDE Usability] Review Request 127054: Add a Filter Toolbar Button for Dolphin

[arnav dhamija]

> On March 11, 2016, 11 a.m., Thomas Lübking wrote:
> > I've no idea what kind of problems you might have encountered by simply using the present action, but adding another action that does the same, just different is very likely to cause async conditions and thus not a good idea at all.
> > 
> > I've no idea whether one needs a toolbutton for this (because it's a keyboard driven feature), but by all means the same action should control it - whether by popup menu, button or shortcut. That's why QAction exists itfp.
> > 
> > => get rid of the additional action and resolve the problemss differently. Ask here or on kde-devel at kde.org if you need help on this.

Thanks for the comment. I have fixed this by replacing the old QAction with a KToggleAction so I can have the toggle functionality in both the menus and the toolbars. The separate action and some superfluous functions have been deleted in the lated revision.


- arnav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127054/#review93413
-----------------------------------------------------------


On March 12, 2016, 8:14 a.m., arnav dhamija wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127054/
> -----------------------------------------------------------
> 
> (Updated March 12, 2016, 8:14 a.m.)
> 
> 
> Review request for Dolphin, KDE Usability and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This patch was created to implement the feature suggested here: [https://todo.kde.org/?controller=task&action=show&task_id=966](https://todo.kde.org/?controller=task&action=show&task_id=966)
> 
> This patch adds a Filter Button to the toolbar of Dolphin. This button can be toggled to show/hide the Filter Bar.
> 
> In this patch, one might notice that there is now show_filter_bar and show_filter_bar_button in dolphinui.rc file. This was done because I found that using the same action for the menu entry and the toolbar entry would cause something to break (eg, shortcuts would stop working). 
> 
> A screenshot of the toolbar is also attached.
> 
> 
> Diffs
> -----
> 
>   dolphinmainwindow.h 7003e94 
>   dolphinmainwindow.cpp f7a7613 
>   dolphinui.rc f197af4 
> 
> Diff: https://git.reviewboard.kde.org/r/127054/diff/
> 
> 
> Testing
> -------
> 
> manual
> 
> 
> File Attachments
> ----------------
> 
> dolphintoolbar.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/12/d936e5d0-557c-45c5-9a2d-f849e5d284a6__dolphintoolbar.png
> 
> 
> Thanks,
> 
> arnav dhamija
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160312/559bfa92/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-usability mailing list
kde-usability at kde.org
https://mail.kde.org/mailman/listinfo/kde-usability