Review Request 128258: location bar can't handle url of type '/path/to/some/local///folder'

[Chinmoy Ranjan Pradhan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128258/#review96738
-----------------------------------------------------------


Ship it!




Ship It!

- Chinmoy Ranjan Pradhan


On June 20, 2016, 4:54 a.m., Chinmoy Ranjan Pradhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128258/
> -----------------------------------------------------------
> 
> (Updated June 20, 2016, 4:54 a.m.)
> 
> 
> Review request for Dolphin and Chinmoy Ranjan Pradhan.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> When dolphin is launched from terminal with argument of type '/path/to/some/local///folder' or '/path/to/some/local///folder/sub-folder' then location bar on the dolphin only shows path upto 'local' in non-editable mode.
> 
> I don't know if the problem is with dolphin or KUrlNavigator but the fix (maybe temporary) is to replace the mutiple slashes with a single slash using QString::split and QStringList::join in global.cpp's validateUris() function. With this patch the final url passed to dolphin will be of form  '/path/to/some/local/folder' and the location bar will show the correct full path. 
> 
> P.S. When in plasma desktop the layout is set to folder view and you open a folder directly from desktop then the path of folder passed to dolphin is of the form "/home/user/Desktop///folder". In editable mode one can see the path as mentioned but in non-editable mode path is only upto Desktop.
> 
> 
> Diffs
> -----
> 
>   src/global.cpp d87a29c 
> 
> Diff: https://git.reviewboard.kde.org/r/128258/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160620/a1ff573d/attachment.htm>