Review Request 127955: [Settings Dialog] Show Trash settings only if authorized

[Emmanuel Pescosta]

> On May 18, 2016, 9:20 p.m., Emmanuel Pescosta wrote:
> > src/settings/dolphinsettingsdialog.cpp, lines 109-111
> > <https://git.reviewboard.kde.org/r/127955/diff/1/?file=465129#file465129line109>
> >
> >     then simply do 
> >     if (KAuthorized::authorizeControlModule(...)) {
> >        m_pages.append(create...());
> >     }
> >     here ;)
> 
> Kai Uwe Broulik wrote:
>     I would end up calling addPage unconditionally then

> calling addPage unconditionally then

What? The createTrashSettings() would only be called if the authorizeControlModule check passes. Do I miss something?


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127955/#review95592
-----------------------------------------------------------


On May 18, 2016, 8:09 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127955/
> -----------------------------------------------------------
> 
> (Updated May 18, 2016, 8:09 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> If this KCM is disabled through KIOSK restriction opening it would result in an error message. Hide the entry altogether in this case.
> 
> 
> Diffs
> -----
> 
>   src/settings/dolphinsettingsdialog.cpp 9eb57f1 
> 
> Diff: https://git.reviewboard.kde.org/r/127955/diff/
> 
> 
> Testing
> -------
> 
> Added
> 
> [KDE Control Module Restrictions]
> kcmtrash.desktop=false
> 
> Got no entry anymore. Without I still get it as before.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160607/58580cf3/attachment.htm>