Review Request 128517: Add DeleteFile and RenameFile standard shortcut

[Leslie Zhai]

> On 七月 26, 2016, 7:44 a.m., David Faure wrote:
> > Looks ok, but is there a reason why there isn't a standard shortcut for "Trash file" too? (Delete)
> > 
> > What makes all this a bit tricky is that IIRC there's an option for making "Delete" really delete rather than trash. But I guess the option could be removed if people can just edit shortcuts. To be checked with the Dolphin people.

Hi David,

Thanks for your review!

> but is there a reason why there isn't a standard shortcut for "Trash file" too? (Delete)

Perhaps ***emacs*** users do not like to use Trash? please see the comment in qtbase http://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/kernel/qplatformtheme.cpp#n181

Waitting for Dolphin group to review ;-)

Regards,
Leslie Zhai


- Leslie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128517/#review97846
-----------------------------------------------------------


On 七月 26, 2016, 9:27 a.m., Leslie Zhai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128517/
> -----------------------------------------------------------
> 
> (Updated 七月 26, 2016, 9:27 a.m.)
> 
> 
> Review request for Dolphin, David Faure and Eike Hein.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> As Eike suggested https://git.reviewboard.kde.org/r/128444/ it is better not to hardcode shortcut, but provided configuration way. so I added DeleteFile and RenameFile shortcut at first, also I changed Qt's keyBindings for Delete and Cut https://bugreports.qt.io/browse/QTBUG-54926 based on a lot of KDE users' desire https://bugs.kde.org/show_bug.cgi?id=344969
> 
> 
> Diffs
> -----
> 
>   src/gui/kstandardshortcut.h 9a2d0d8 
>   src/gui/kstandardshortcut.cpp 6be6309 
> 
> Diff: https://git.reviewboard.kde.org/r/128517/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160726/cad83c31/attachment.htm>